[c++] Remove duplicated code in DynamicParser #737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chwarr
requested changes
Nov 29, 2017
cpp/inc/bond/core/parser.h
Outdated
| @@ -522,6 +491,13 @@ class DynamicParser | |||
| else | |||
| return detail::BasicTypeField(id, schema<Unknown>::type::metadata, type, BindUnknownField(transform), _input); | |||
| } | |||
|
|
|||
|
|
|||
| void ReadFieldEndBegin(BondDataType& type, uint16_t& id) | |||
| // 2) We parsed only part of the hierarchy because that was what | ||
| // the transform "expected". | ||
| // | ||
| // In both cases we emit remaining fields as unknown |
There was a problem hiding this comment.
There's a bug here that we probably should fix before refactoring. If we're parsing and we detect that we're in an unexpected hierarchy depth, that should cause serialization--and perhaps other transforms--to fail.
There was a problem hiding this comment.
Why do you think that needs to be fixed before this change? Also won't the fix likely be in detail::ParserInheritance?
There was a problem hiding this comment.
Take a look at issue #742 for the details of the problem.
chwarr
approved these changes
Dec 11, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.