[c++ grpc] Fix includes when bond::Void is used #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a service contains events or parameterless methods, the generated code uses bond::Void as the request/result type. To serialize bond::Void, bond_reflection.h needs to be included. The generated service code now includes bond_reflection.h if any service contains an event or a parameterless method. Fixes microsoft#735
|
@chwarr, is it possible to use gRPC with |
lalo
approved these changes
Nov 29, 2017
|
It should work with bond_apply.lib; however, you'd have to make sure to |
ara-ayvazyan
approved these changes
Dec 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a service contains events or parameterless methods, the generated
code uses bond::Void as the request/result type. To serialize
bond::Void, bond_reflection.h needs to be included.
The generated service code now includes bond_reflection.h if any service
contains an event or a parameterless method.
Fixes #735