This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Added app version check for Android for consistency with iOS approach #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… (this is for 'insurance' that old packages will be cleared even if the timestamps are wrong because the app version is always bumped in production).
|
@max-mironov, |
richardhuaaa
approved these changes
Mar 2, 2017
| try { | ||
| applicationVersion = Utilities.getAppVersionName(this.cordova.getActivity()); | ||
| } catch (PackageManager.NameNotFoundException e) { | ||
| e.printStackTrace(); |
There was a problem hiding this comment.
I'm guessing we expect this exception should basically never happen right?
There was a problem hiding this comment.
Yes, I thought about it too, I believe that if we don't have version defined than the app is not correct at all.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for 'insurance' that old packages will be cleared even if the timestamps are wrong because the app version is always bumped in production.