This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Add stacktrace logging #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruslan-bikkinin
force-pushed
the
add-stacktrace-logging
branch
from
43db2a8 to
e2f9ab7
Compare
sergey-akhalkov
suggested changes
Dec 25, 2017
www/codePushUtil.ts
Outdated
| @@ -66,7 +66,11 @@ class CodePushUtil { | |||
| */ | |||
| public static logError(message: String, error?: Error): void { | |||
| var errorMessage = message || "" + " " + CodePushUtil.getErrorMessage(error); | |||
| console.error(CodePushUtil.TAG + " " + errorMessage); | |||
| var stackTrace = ''; | |||
There was a problem hiding this comment.
It would be great to use let instead of var and const instead of let if possible.
www/codePushUtil.ts
Outdated
| if (error.stack) { | ||
| stackTrace += '. Stacktrace: ' + error.stack; | ||
| } | ||
| console.error(CodePushUtil.TAG + " " + errorMessage + stackTrace); |
There was a problem hiding this comment.
Let's use template literals for text formatting instead of +
bin/www/codePushUtil.js
Outdated
| console.error(CodePushUtil.TAG + " " + errorMessage); | ||
| var stackTrace = ''; | ||
| if (error.stack) { | ||
| stackTrace += '. Stacktrace: ' + error.stack; |
There was a problem hiding this comment.
Stacktrace -> StackTrace
ruslan-bikkinin
force-pushed
the
add-stacktrace-logging
branch
from
7801b9b to
8a63002
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add stacktrace logging which is will be very handy to debug errors.