This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Move dtscritic to tslint rule #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because dts-critic inspects the filesystem, and the test filesystem has extra .lint extensions, and I don't care enough to make it understand the tslint test environment.
I had to hack dts-critic though, with a new entry point: ```js /** @param {string} dts - the text of the d.ts */ dtsCritic.alternate = function (dts, dtsPath) { let header; try { header = headerParser.parseHeaderOrFail(dts); } catch(e) { header = undefined; } const names = findNames(dtsPath, undefined, header) const src = download("https://unpkg.com/" + mangleScoped(names.src)); checkNames(names, header); if (header && !header.nonNpm) { checkSource(names.dts, dts, src); } } ``` and modified findDtsName to know about .lint extension in tests. This second thing is not good and should probably be inverted as well: ``` /** * If dtsName is 'index' (as with DT) then look to the parent directory for the name. * @param {string} dtsPath */ function findDtsName(dtsPath) { const resolved = path.resolve(dtsPath); const baseName = path.basename(resolved, '.d.ts'); if (baseName && baseName !== "index") { const baseName2 = path.basename(resolved, '.d.ts.lint'); if (baseName2 && baseName2 !== "index") { return baseName; } } return path.basename(path.dirname(resolved)); } ```
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it's possible to turn it off!
Since it reads from the file system, it is hard to test with tslint's test framework. I tested it manually instead.