Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Fix banned words check and update dts-critic #236

Merged
merged 3 commits into from
Jun 6, 2019

Conversation

sandersn
Copy link
Member

@sandersn sandersn commented Jun 5, 2019

  1. Update to dts-critic 1.2, which no longer requires project urls to include the homepage url specified on npm.
  2. Check for banned words for all packages, not just those complex enough to have a package.json. The location of the check was wrong.

sandersn added 2 commits June 5, 2019 14:55
1. Update to dts-critic 1.2, which no longer requires project urls to
include the homepage url specified on npm.
2. Check for banned words for all packages, not just those complex
enough to have a package.json. The location of the check was wrong.
@andrewbranch
Copy link
Member

I'm not familiar with the “download” rule. Have you seen this? https://github.com/npm/validate-npm-package-name

@sandersn
Copy link
Member Author

sandersn commented Jun 6, 2019

It doesn't test against npm's spam filter :(

> var v = require('validate-npm-package-name')
undefined
> v('download-file-async')
{ validForNewPackages: true, validForOldPackages: true }

@sandersn
Copy link
Member Author

sandersn commented Jun 6, 2019

I opened npm/validate-npm-package-name#23, but I'm not holding my breath because it hasn't published an update in 2 years, and @brettz9 opened a PR two months ago that hasn't been looked at.

@sandersn sandersn merged commit 6e3891a into master Jun 6, 2019
@sandersn sandersn deleted the fix-banned-words-check branch June 6, 2019 20:37
@sandersn
Copy link
Member Author

sandersn commented Jun 6, 2019

Published [email protected]

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants