Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Update checks.ts #240

Merged
merged 1 commit into from
Aug 6, 2019
Merged

Update checks.ts #240

merged 1 commit into from
Aug 6, 2019

Conversation

cortopy
Copy link
Contributor

@cortopy cortopy commented Aug 4, 2019

Not all type definitions use React.createElement as the jsx pragma. I bumped into this issue when updating storybook__preact types as per DefinitelyTyped/DefinitelyTyped#37275

By adding the compiler option jsxFactory other pragmas can be used in type definitions

Not all type definitions use `React.createElement` as the jsx pragma. I bumped into this issue when updating `storybook__preact` types as per DefinitelyTyped/DefinitelyTyped#37275

By adding the compiler option `jsxFactory` other pragmas can be used in type definitions
@cortopy
Copy link
Contributor Author

cortopy commented Aug 4, 2019

Ci failing for issues in @types/node which are not related to this commit

@sandersn
Copy link
Member

sandersn commented Aug 6, 2019

Looks like I need to update the @types/node dependency.

@sandersn sandersn merged commit 2586a69 into microsoft:master Aug 6, 2019
@sandersn
Copy link
Member

sandersn commented Aug 6, 2019

I published 0.9.1, which has this change and the updated @types/node dependency. New PRs on DT should get this version of dtslint.

@cortopy cortopy deleted the patch-1 branch August 7, 2019 08:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants