Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Update npm naming #269

Merged
merged 13 commits into from
Feb 14, 2020
Merged

Update npm naming #269

merged 13 commits into from
Feb 14, 2020

Conversation

gabritto
Copy link
Member

Updates to npm naming rule to be compatible with new dts-critic checks.

@gabritto gabritto requested a review from sandersn February 13, 2020 18:36
gabritto
gabritto commented Feb 13, 2020
View reviewed changes
package.json Outdated Show resolved Hide resolved
sandersn
sandersn reviewed Feb 13, 2020
View reviewed changes
Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of things I noticed.

src/rules/npmNamingRule.ts Show resolved Hide resolved
src/rules/npmNamingRule.ts Outdated Show resolved Hide resolved
@gabritto gabritto marked this pull request as ready for review February 14, 2020 23:17
@gabritto gabritto merged commit 9c56a82 into master Feb 14, 2020
@gabritto gabritto deleted the updateNpmNaming branch February 14, 2020 23:43
haaami01
haaami01 reviewed Jan 4, 2021
View reviewed changes
Copy link

@haaami01 haaami01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update your documents. I hope you're meeting your expectations exactly.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@haaami01 haaami01 haaami01 left review comments

@sandersn sandersn sandersn left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gabritto @sandersn @haaami01