This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Use TypeScriptVersion.latest instead of "next" #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dtslint installs the latest version of typescript as "next" because that's the npm name. Probably a better fix is to install typescript@next into a directory with the same name as the rest, stripping off the .0-dev.20200323 part.
This removes the need to change the name when testing dependencies. I'm not sure yet about when testing the main package.
Instead, just use TYpeScriptVersion.latest everywhere except when installing from npm.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except when installing from npm. definitelytyped-header-parser has it right, but dtslint previously went through hoops to add "next" so that it could install
typescript@nextfrom npm. This PR reduces the scope of that addition to justinstaller.ts. Everywhere else just treats the next version as a normal version number.