This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Support parallel minor versions #282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alloy
commented
Mar 27, 2020
alloy
commented
Mar 27, 2020
| @@ -76,8 +76,7 @@ export function assertDefined<T>(a: T | undefined): T { | |||
| } | |||
|
|
|||
| export async function mapDefinedAsync<T, U>( | |||
| arr: Iterable<T>, mapper: (t: T) => Promise<U | undefined>): | |||
| Promise<Array<awaited U>> { | |||
| arr: Iterable<T>, mapper: (t: T) => Promise<U | undefined>): Promise<U[]> { | |||
There was a problem hiding this comment.
Running npm install gave me the latest next, rather than the one recorded in the lockfile, and it seems like awaited was recently reverted.
sandersn
suggested changes
Mar 27, 2020
alloy
force-pushed
the
support-minor-versions
branch
from
32def61 to
be2cff8
Compare
|
Currently these are allowed: Whereas this is disallowed: The above should all be allowed now, but not those with patch components: |
sandersn
approved these changes
Mar 30, 2020
|
I published 3.4.1 just now, so Definitely Typed's CI should get the new version next time it runs. |
|
Thanks! 🙏 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to microsoft/types-publisher#723.
This was causing CI on DT to fail for DefinitelyTyped/DefinitelyTyped#43179.
I couldn't figure out how to write a test to exercise this code-path. If it’s easy to point out, I’d gladly add test coverage.