This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Update to 4.0, deprecate 2.8 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also switch from definitelytyped-header-parser to @definitelytyped/header-parser, @definitelytyped/typescript-versions, @definitelytyped/utils. This brings a couple of updates, principally a new way of tracking which TS versions have shipped under the "latest" tag vs shipped under the "next" tag. dtslint tests *only* versions that have shipped under "latest", plus whatever is *currently* shipping under "next". It doesn't test any betas or RCs. Note that the new dependencies are currently closed source. We're waiting on the MS open source legal office to OK the new repos.
sandersn
commented
Apr 28, 2020
| @@ -186,15 +186,20 @@ function range(minVersion: TsVersion, maxVersion: TsVersion): ReadonlyArray<TsVe | |||
| assert(maxVersion === "local"); | |||
| return ["local"]; | |||
| } | |||
There was a problem hiding this comment.
this function is the only substantive change, from supported to shipped+latest.
sandersn
commented
Apr 28, 2020
tsconfig.json
Outdated
| @@ -13,7 +13,8 @@ | |||
| "noImplicitThis": true, | |||
| "noUnusedLocals": true, | |||
| "noUnusedParameters": true, | |||
| "strictNullChecks": true | |||
| "strictNullChecks": true, | |||
There was a problem hiding this comment.
forgot that prettier doesn't run on this repo =(
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also
These dependencies bring a new way of tracking which TS versions have shipped under the "latest" tag vs shipped under the
"next" tag. That's important because dtslint tests only versions that have shipped under "latest", plus whatever is currently shipping under "next". It doesn't test any betas or RCs.
Note that the new dependencies are currently closed source. We're waiting on the MS open source legal office to OK the new repos.