Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Make dtslint work for directories with minor versions #334

Closed
wants to merge 1 commit into from

Conversation

rurikoaraki
Copy link

Fixes #333

This PR will allow the dtslinter to work with directories that contain minor version numbers. For example if I define a v0.63 directory, these changes will allow dtslinter to correctly lint that directory.

Changed some regex's in the index and util files to account for minor versions. Added some tests to ensure that the behavior is working as intended.

Bumping package.json version so that these changes can be used by DT.

Ran tests and the dt-header tests run as expected.

@rurikoaraki
Copy link
Author

Pinging @orta as well in case sandersn is away

@fedemp
Copy link

fedemp commented Jun 22, 2021

This PR would unblock this another PR. DefinitelyTyped/DefinitelyTyped#53834

@sandersn
Copy link
Member

sandersn commented Jul 30, 2021

Arggh! Sorry, I messed up and missed this PR. I ended up making #338 independently, which is basically the same, just slightly stricter.

@fedemp did the earlier version of DefinitelyTyped/DefinitelyTyped#53834 need a minor version greater than 0.*? If so, maybe this PR is better; however, I'd have to go check that the publisher also supports minors greater than 0.*

@rurikoaraki I reopened DefinitelyTyped/DefinitelyTyped#53595 to test whether the new version of dtslint lets it pass.
Edit: It does.

@rurikoaraki
Copy link
Author

rurikoaraki commented Jul 30, 2021

@sandersn No worries! Thanks for fixing this! I'll close this PR out.

ETA: The PR on DT seems to have passed CI.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dtslint doesn't support older versions that have minor version numbers
3 participants