Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: FluentUI ContextualMenu Accessibility Issue aria-allowed-attr #27593

Closed
2 tasks done
mzavala722 opened this issue Apr 17, 2023 · 2 comments
Closed
2 tasks done

Comments

@mzavala722
Copy link

Library

React / v8 (@fluentui/react)

System Info

Package version: @fluentui/react: 8.93.1

Are you reporting Accessibility issue?

yes

Reproduction

https://developer.microsoft.com/en-us/fluentui#/controls/web/contextualmenu

Bug Description

Repro Steps

Actual Behavior

Implementations of the FluentUI ContextualMenu are currently failing the Accessibility Insights for Web fast pass. See screenshots and attached logs.

image
image

Expected Behavior

The ContextualMenu component should pass the Accessibility Insights for Web fast pass without any accessibility issues.

Logs

Accessibility Insights for Web fast pass failure details:

Title: WCAG 4.1.2: Ensures ARIA attributes are allowed for an element's role (.splitContainer-422[aria-posinset="6"][role="menuitemcheckbox"])
Tags: Accessibility, WCAG 4.1.2, aria-allowed-attr

Issue: Ensures ARIA attributes are allowed for an element's role (aria-allowed-attr - https://accessibilityinsights.io/info-examples/web/aria-allowed-attr)

Target application: Fluent UI - Controls - React - ContextualMenu - https://developer.microsoft.com/en-us/fluentui#/controls/web/contextualmenu

Element path: .splitContainer-422[aria-posinset="6"][role="menuitemcheckbox"]

Snippet: <div role="menuitemcheckbox" class="splitContainer-422" aria-disabled="false" aria-expanded="false" aria-haspopup="true" aria-posinset="6" aria-setsize="10" tabindex="-1" data-is-focusable="true">

How to fix: 
Fix any of the following:
  ARIA attribute is not allowed: aria-expanded="false"

Environment: Microsoft Edge version 112.0.1722.39

====

This accessibility issue was found using Accessibility Insights for Web 2.38.1 (axe-core 4.6.3), a tool that helps find and fix accessibility issues. Get more information & download this tool at http://aka.ms/AccessibilityInsights.

Requested priority

Blocking

Products/sites affected

No response

Are you willing to submit a PR to fix?

no

Validations

  • Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
  • The provided reproduction is a minimal reproducible example of the bug.
@github-actions github-actions bot added the Fluent UI react (v8) Issues about @fluentui/react (v8) label Apr 17, 2023
@khmakoto
Copy link
Member

Hi @mzavala722, this seems like it is a false positive in the axe-core checks.

You can see that aria-expanded is an allowed state for the menuitemcheckbox role in the ARIA spec.

We have filed an issue on axe-core regarding this, so I'll be resolving this issue as Resolution: External.

Let us know if there is anything else we can do to help!

@msft-fluent-ui-bot
Copy link
Collaborator

This issue has been automatically marked as stale because it has marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment. Thank you for your contributions to Fluent UI!

@microsoft microsoft locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants