Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

False positive aria-allowed-attr for aria-expanded on menuitemcheckbox and menuitemradio #3992

Closed
1 task done
smhigley opened this issue Apr 18, 2023 · 2 comments · Fixed by #3994
Closed
1 task done
Labels
fix Bug fixes rules Issue or false result from an axe-core rule

Comments

@smhigley
Copy link
Contributor

Product

axe-core

Product Version

No response

Latest Version

  • I have tested the issue with the latest version of the product

Issue Description

Expectation

aria-expanded is an allowed attribute on both menuitemcheckbox and menuitemradio (ref: https://w3c.github.io/aria/#menuitemcheckbox).

Actual

axe-core currently returns an aria-allowed-attr failure when it is added to either role.

How to Reproduce

Simplest repro: https://jsfiddle.net/fu9ve7gp/show

Additional context

Looks like the issue is here: https://github.com/dequelabs/axe-core/blob/develop/lib/standards/aria-roles.js#L377-L396

#3343 would fix it along with some other aria-expanded support mismatches, but since it's over a year old I wasn't sure if it was still active.

@smhigley smhigley added the ungroomed Ticket needs a maintainer to prioritize and label label Apr 18, 2023
@straker
Copy link
Contributor

straker commented Apr 19, 2023

Thanks for the issue. That particular pr was put on hold until we could figure out how to inform users of deprecated allowances. However, if you'd like to create a pr that just adds aria-expanded to the needed roles, that would be great.

@straker straker added fix Bug fixes rules Issue or false result from an axe-core rule and removed ungroomed Ticket needs a maintainer to prioritize and label labels Apr 19, 2023
@smhigley
Copy link
Contributor Author

@straker sure, I'd be happy to!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Bug fixes rules Issue or false result from an axe-core rule
Projects
None yet
2 participants