Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This short PR attempts to fix the radio-group's value setting.
In the current code, inferring a radio-group's initial value from a checked radio child does not work properly:
-1
tabindex)Both of these behaviors stem from the fact that the value setter's logic is not called. This PR corrects that by triggering it in the slot change handler.
I've also taken the opportunity to:
Updates.enqueue
from this handler as it defers the component initialization (first call toradiosChanged
) to the next event loop tick, which is not great UX if authors want to get the value early (e.g., in a whenDefined call).checkRadio()
byradio.click()
in radio-group so that keyboard navigation would also emit the proper events.(Not related but, for some reason, there is code that unchecks a radio when it becomes disabled. I'm not sure that's wanted as it is a strange departure from native behavior, so I also removed that.)