chore: remove usage of "export *" [part 2] #33384
Open
+1,881
−551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
layershifter
force-pushed
the
chore/remove-export-star-2
branch
from
aa96216
to
2c2f470
Compare
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
layershifter
force-pushed
the
chore/remove-export-star-2
branch
6 times, most recently
from
c16412f
to
2c69789
Compare
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
layershifter
force-pushed
the
chore/remove-export-star-2
branch
2 times, most recently
from
8ca88a4
to
13a23a8
Compare
fabricteam
reviewed
Dec 2, 2024
| @@ -0,0 +1,7 @@ | |||
| { | |||
There was a problem hiding this comment.
🕵🏾♀️ visual regressions to review in the fluentuiv9 Visual Regression Report
Avatar Converged 1 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Avatar Converged.badgeMask.chromium.png | 45 | Changed |
Drawer 3 screenshots
| Image Name | Diff(in Pixels) | Image Type |
|---|---|---|
| Drawer.Full Overlay Dark Mode.chromium.png | 984 | Changed |
| Drawer.Full Overlay High Contrast.chromium.png | 2232 | Changed |
| Drawer.Full Overlay RTL.chromium.png | 1171 | Changed |
layershifter
force-pushed
the
chore/remove-export-star-2
branch
from
13a23a8
to
641e669
Compare
layershifter
force-pushed
the
chore/remove-export-star-2
branch
from
641e669
to
b208264
Compare
layershifter
requested review from
a team,
sopranopillow,
marcosmoura,
GeoffCoxMSFT and
dmytrokirpa
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous Behavior
export *is used in a lot of files.New Behavior
No API changes
export *is replaced with exact exports. This will improve performance of current compiler in Griffel and will unblock the future one, see microsoft/griffel#621.Note: I used autofix via
--fixon ESLint, so some other things were fixed (unused ESLint supressions, etc.).