[release/0.11] Add support for platform compatibility check for windows + fix integration test failures #1878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helsaawy
approved these changes
Aug 31, 2023
kiashok
changed the title
helsaawy
approved these changes
Aug 31, 2023
katiewasnothere
approved these changes
Aug 31, 2023
helsaawy
approved these changes
Aug 31, 2023
) Signed-off-by: Kirtana Ashok <[email protected]> (cherry picked from commit 640a560) Signed-off-by: Kirtana Ashok <[email protected]>
kiashok
force-pushed
the
portStableABI
branch
from
a406558
to
439e2dd
Compare
katiewasnothere
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is backporting the following commit to release/0.11
640a560
(cherry picked from commit 640a560)
Note: there could be some CI test failures but they are failures that exist on v0.10.0-rc.8 tag that release/0.11 is based off of. We need the stable ABI changes in upstream to unblock stable ABI work for annual channel Zn release. Fix all the test failures need up to update the containerd version used in go.mod file and this in turn is causing grpc changes while vendoring into containerd/1.7 and upstream seems to have a problem with it.
Since the tests are already present in rc8 tag and aren't new, we should be ok to check in this fix with CI failures (mainly to unblock annual channel work). Once that is done, we can update all tests and containerd tag and have a conversation with upstream folks about this.