Update build tags, lint entire repo for Linux #1968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
helsaawy
force-pushed
the
linux-tags
branch
2 times, most recently
from
b80bd98
to
8b6524a
Compare
Add (Windows) build tags to necessary files, and add `internal\vhdx\doc.go` so that go language server does not complain that package is missing on Linux. Not all updated files are Windows specific. Some (eg, `internal\gcs\iochannel.go`) are only used by Windows code, so the go build tag prevents `unused` lint errors when `GOOS=linux`. Export the `parseAnnotations(Uint32|Uint64|String)` functions in `internal\oci\annotations.go` since other functions in the file are used in Linux files and that was the only way to avoid `unused` lint errors. Finally updated lint (in `.github\workflows\ci.yml`) and codeql (in `.github\workflows\codeql.yml`) jobs to run on entire repo for Linux, rather then specific directories. Signed-off-by: Hamza El-Saawy <[email protected]>
katiewasnothere
approved these changes
Nov 13, 2023
anmaxvl
approved these changes
Nov 13, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
Add (Windows) build tags to necessary files, and add `internal\vhdx\doc.go` so that go language server does not complain that package is missing on Linux. Not all updated files are Windows specific. Some (eg, `internal\gcs\iochannel.go`) are only used by Windows code, so the go build tag prevents `unused` lint errors when `GOOS=linux`. Export the `parseAnnotations(Uint32|Uint64|String)` functions in `internal\oci\annotations.go` since other functions in the file are used in Linux files and that was the only way to avoid `unused` lint errors. Finally updated lint (in `.github\workflows\ci.yml`) and codeql (in `.github\workflows\codeql.yml`) jobs to run on entire repo for Linux, rather then specific directories. Signed-off-by: Hamza El-Saawy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add (Windows) build tags to necessary files, and add
internal\vhdx\doc.goso that go language server does not complain that package is missing on Linux.Not all updated files are Windows specific; some (eg,
internal\gcs\iochannel.go) contain un-exported code that is only used in Windows-specific code. In those cases, the//go:build windowstag preventsunusedlint errors whenGOOS=linux.Export the
parseAnnotations(Uint32|Uint64|String)functions ininternal\oci\annotations.gosince other functions in the file are used in Linux files and that was the only way to avoidunusedlint errors.Update the lint (in
.github\workflows\ci.yml) and codeql (in.github\workflows\codeql.yml) jobs to run on entire repo for Linux, rather than in a specific set directories.