Fix issue with mask length of gateway addresses #2305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevpar
reviewed
Nov 2, 2024
kevpar
reviewed
Nov 2, 2024
interface's subnet * See documentation at https://pkg.go.dev/net#ParseIP Signed-off-by: Kathryn Baldauf <[email protected]>
katiewasnothere
force-pushed
the
user/kabaldau/fix_parse_ip
branch
from
c6e6b36
to
20a24ef
Compare
kevpar
approved these changes
Nov 4, 2024
anmaxvl
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In more recent golang versions, net library's implementation of ParseIP was changed to always return a byte array of length 16 whether or not the parsed IP is IPv4 or IPv6 (see here). However, the GCS was relying on the length of ParseIP to match the IP type when calculating a mask length before adding the gateway address.
Without this change, a mask length of 128 is always created in cases where we add a gateway address that is outside the interface's subnet. If the gateway IP is IPv4 and the mask length is 128, then the call to
netlink.AddrAddwill returninvalid argumentand we will fail to create a pod.