Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds support for OpenAPI 3.1 descriptions #5936

Open
wants to merge 117 commits into
base: main
Choose a base branch
from
Open

adds support for OpenAPI 3.1 descriptions #5936

wants to merge 117 commits into from

Conversation

baywet
Copy link
Member

@baywet baywet commented Dec 23, 2024 •
edited
Loading

fixes #3914

depends on microsoft/OpenAPI.NET#2023

In addition to "supporting the new format" this PR does a couple of things:

  • adds early support for external references.
  • adds support for type arrays (["number", "string"]) and projects them as union types.

baywet added 30 commits November 12, 2024 04:37
@baywet
fix: oas extensions parsing
85194e4 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: multiple NRE
d83bc2f 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: additional NRE
99623e1 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: updates reference to oai.net preview
8392023
@baywet
fix: additional 3.1 NRT and type reference fixes
25e4511
@baywet
fix: additional 3.1 NRT and type reference fixes
99dcbfb
@baywet
fix: wrong value comparison
6422b45 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: additional type and NRT fixes
4bff227 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: main project builds
229a425 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: all validation tests migrated to the new OAI.net object model
193a7b9 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: openapi extension migrated to new OAI.net model
294d80e 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: main tests build
2d87938 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
Merge branch 'main' into feat/OAI-3-1
453bf9d 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: parsing of dependencies
57c7cb9 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: aligns dependencies versions
5db7ad0 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
Merge branch 'main' into feat/OAI-3-1
2360204
@baywet
chore: upgrades additional code
4c1866d
@baywet
Merge branch 'main' into feat/OAI-3-1
291db8a 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: upgrades to OAI.net preview3
4daed72 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: registers missing reader
9c9f988 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: bad boolean algebra
9cebd6c 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
chore: linting
893a5ae 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: class naming for discriminator mapping
c1e21aa 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: further fix of missing reference ids
5f7e287 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: wrong method overload use
77f3a55 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: wrong test data
66641be 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: missing readers
52ede22 
fix: missing descriptions

Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: form encoded validation rule
85c67cd 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
fix: validation rules registration
bc64b83 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
Merge branch 'main' into feat/OAI-3-1
21c607f 
Signed-off-by: Vincent Biret <[email protected]>
@baywet
Copy link
Member Author

baywet commented Feb 14, 2025

most idempotency and integration tests seem to be failing because of this microsoft/OpenAPI.NET#2149

@baywet baywet requested a review from andrueastman February 14, 2025 15:49
@baywet baywet marked this pull request as ready for review February 14, 2025 20:13
@baywet baywet requested a review from a team as a code owner February 14, 2025 20:13
@baywet
Copy link
Member Author

baywet commented Feb 14, 2025

and the unit tests are impacted by this bug microsoft/OpenAPI.NET#2150

andrueastman
andrueastman approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@andrueastman andrueastman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

src/Kiota.Builder/OpenApiExtensions/OpenApiKiotaMergedExtension.cs Show resolved Hide resolved
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed for 'kiota'

Issues
21 New issues
0 Accepted issues

Measures
0 Security Hotspots
80.3% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@baywet
Copy link
Member Author

baywet commented Feb 19, 2025 •
edited
Loading

for anybody following along, we'll need to wait for the release of this fix.
microsoft/OpenAPI.NET#2157

microsoft/OpenAPI.NET#2158

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrueastman andrueastman andrueastman approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

@baywet baywet

Labels
None yet
Projects
Kiota
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for handling OpenAPI v3.1 definitions
3 participants
@baywet @cpriestland @andrueastman