Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bracket Matching Does Not Work For Inner Languages #3534

Closed
hediet opened this issue Feb 7, 2023 · 2 comments · Fixed by #3878 · 4 remaining pull requests
Closed

Bracket Matching Does Not Work For Inner Languages #3534

hediet opened this issue Feb 7, 2023 · 2 comments · Fixed by #3878 · 4 remaining pull requests
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@hediet
Copy link
Member

hediet commented Feb 7, 2023

Playground Code:

// The Monaco Editor can be easily created, given an
// empty container and an options literal.
// Two members of the literal are "value" and "language".
// The editor takes the full size of its container.

monaco.editor.create(document.getElementById('container'), {
	value: "```js\n()\n```",
	language: 'markdown'
});

Notice how brackets are not matched:
image

I believe this is caused by this commit @alexdima (it works with the nightly release before):
microsoft/vscode@cc527241

image

@hediet hediet added the bug Issue identified by VS Code Team member as probable bug label Feb 7, 2023
@alexdima alexdima added this to the February 2023 milestone Feb 7, 2023
@qqaimh
Copy link

qqaimh commented Feb 16, 2023

come on !I need this feature urgently !

@alexdima
Copy link
Member

Once microsoft/vscode#175331 lands in main, we can adopt onLanguageEncountered for loading up configuration files.

alexdima added a commit to microsoft/vscode that referenced this issue Feb 24, 2023
…ests (microsoft/monaco-editor#3534) (#175331)

* Use `ILanguageService` to broker basic or rich language features requests (microsoft/monaco-editor#3534)

* Remove unnecessary diff
sourcegraph-bot pushed a commit to sgtest/megarepo that referenced this issue Feb 24, 2023
…res requests (microsoft/monaco-editor#3534) (#175331)

Commit: 48922837ccf690341cc2aa796b6859d35a79baa6
@alexdima alexdima modified the milestones: March 2023, April 2023 Mar 24, 2023
@hediet hediet modified the milestones: April 2023, March 2023 Mar 31, 2023
@hediet hediet mentioned this issue Mar 31, 2023
hediet added a commit that referenced this issue Mar 31, 2023
@github-actions github-actions bot locked and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.