Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Azure env credential authentication #722

Merged
merged 9 commits into from
Oct 10, 2023

Conversation

ianhelle
Copy link
Contributor

@ianhelle ianhelle commented Oct 6, 2023

Fixing azure environment authentication - allowing all 3 combos of credentials (client secret, user password and certificate).

@ianhelle ianhelle requested a review from petebryan October 6, 2023 21:34
In process tree builder it creates dummy timestamps for inferred parent processes. These were created with:
`pd.Timestamp(0, tz=0)`. However this produces a slightly different type of TZ-aware timestamp object than the source data. This means that the values cannot be processed by the .dt accessor.
Fixed to use TZ object derived from input data.
Error:
AttributeError: Can only use .dt accessor with datetimelike values
Copy link
Collaborator

@FlorianBracq FlorianBracq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@petebryan petebryan merged commit 61ed9dc into main Oct 10, 2023
@petebryan petebryan deleted the ianhelle/fix-env-auth-2023-10-02 branch October 10, 2023 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Username-Password Credentials in Environmental Variables don't Work
3 participants