-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jwt auth token expire check and modify some messages when connecting Splunk #770
Add jwt auth token expire check and modify some messages when connecting Splunk #770
Conversation
update to latest
updates to latest
Oops, I noticed pulled my folk repository's main instead of microsoft:main before this commit. I'm sorry. |
Got it, I have completely fixed. Thank you in advance for your eye, @ianhelle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but a couple of minor issues.
Thanks for your check and the advices.
Would you kindly check them again? |
Thanks for your approval and merge. |
@Tatsuya-hasegawa - thank you, once again for the contribution. It's awesome to have someone actively working on the Splunk support! |
Hello,
I have some additional things to SplunkDriver.
The biggest one is that JWT bear_token's expiration check was implemented by using pyjwt which is already in requirement.txt.
In addition, I put some distinguish messages for each auth method when connecting Splunk.
And then modify an error in Splunk QueryProvider doc.
Local code check has been succeeded as following.
The JWT expiration time is shown by this commit.
This is an expire message, in this case, I modified the current time to over the expiration date forcely in order to appear this message.
Thank you.
Best regards,