Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing np.NaN error and build warnings #785

Merged
merged 5 commits into from
Jun 28, 2024

Conversation

ianhelle
Copy link
Contributor

Fixing pandas deprecation warnings in vtfile_behaviour and process_tree_utils.
The rest is mostly suppressing expected warnings in unit tests

ianhelle added 2 commits June 27, 2024 10:56
Fixing pandas deprecation warnings in vtfile_behaviour and process_tree_utils.
The rest is mostly suppressing expected warnings in unit tests
Updating linting CI task to Py 3.11
Suppressing unreachable code pylint warning since it seems to be reporting nonsense.
Updating python-package.yml to use node 20 actions
@ianhelle ianhelle added bug Something isn't working build_break labels Jun 27, 2024
Copy link
Collaborator

@ryan-detect-dot-dev ryan-detect-dot-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/context/test_vtlookupv3.py Show resolved Hide resolved
@ianhelle ianhelle self-assigned this Jun 27, 2024
@FlorianBracq
Copy link
Collaborator

That looks good to me too!

@ianhelle
Copy link
Contributor Author

Merging this despite AzDevops pipeline failure (AV checks on some examples in our documentation and tests - which are really examples of malicious PS scripts). Working on this while I try to work out how to implement suppressions for these

@ianhelle ianhelle merged commit d5baf24 into main Jun 28, 2024
9 checks passed
@ianhelle ianhelle deleted the ianhelle/mp-numpy-and-buildwarnings-2024-06-27 branch June 28, 2024 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working build_break
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants