Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TILookup and ContextLookup #794

Merged
merged 23 commits into from
Aug 7, 2024
Merged

Update TILookup and ContextLookup #794

merged 23 commits into from
Aug 7, 2024

Conversation

FlorianBracq
Copy link
Collaborator

Update lookups to expand kwargs to ensure keywod arguments are named and visible.
Add typing for pa to most of the functions to ensure consistency and proper mypy support.
Apply ruff recommendations:

  • Typing with list/tuple/dict/set instead of List/Tuple/Dict/Set
  • Add ClassVar types
  • Replace Optional and Union by new "pipe notation"
  • Add timezone to datetime objects

FlorianBracq and others added 21 commits June 26, 2024 16:47
@FlorianBracq
Improve typing for export decorator
ebcfd91
@FlorianBracq
wip: Add typing to base providers
2c09495
@FlorianBracq
wip: Add typing to lookups
192adc7
@FlorianBracq
wip: Add typing to context providers
191ed26
@FlorianBracq
wip: Add typing to tiproviders
52307e2
@FlorianBracq
Minor changes on tests
f019f64
@FlorianBracq
wip: typing for context providers
e27e60f
@FlorianBracq
WIP: Apply typing to various objects from msticpy.context
1c66e1c
@FlorianBracq
Inherit from httpx to define test objects
40b0225
@FlorianBracq
Add requests as a dependency for riskiq
f804483
@FlorianBracq
WIP - Add typing to lookup
e2cc0fa
@FlorianBracq
WIP - Fix linting errors
c6dec35
@FlorianBracq
Merge branch 'main' of https://github.com/FlorianBracq/msticpy into u…
8ee18d4 
…pdate-tiproviders-contextproviders
@FlorianBracq
[WIP] Apply linting to ti providers
197cce8
@FlorianBracq
Adding requests to dependencies
154b8e4
@FlorianBracq
[WIP] Apply linting to ti providers + fix bugs
42ab8d6
@FlorianBracq
Remove kwargs
28f9211
@FlorianBracq
Fix black linting
d344f90
@FlorianBracq
Fix pylint errors
a3eeda6
@FlorianBracq
Fix mypy errors
9c2fc48
@FlorianBracq
Fix Flake8 error
5e7ce80
@ianhelle
Copy link
Contributor

Wow Florian. You've gone above and beyond the call of duty here. Amazing work!
I'm assuming/hoping that you had some tool assistance with this.

ianhelle
ianhelle requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@ianhelle ianhelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just the kwargs: str type annotation

conda/conda-reqs-pip.txt Outdated Show resolved Hide resolved
msticpy/context/vtlookupv3/vtlookup.py Show resolved Hide resolved
@ianhelle ianhelle merged commit d2a7a73 into microsoft:main Aug 7, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ianhelle ianhelle ianhelle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FlorianBracq @ianhelle