Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Mock for Mock Smm Sw Dispatch2 Protocol #1217

Merged
merged 11 commits into from
Dec 12, 2024

Conversation

Rasheed-Yusuf
Copy link
Contributor

@Rasheed-Yusuf Rasheed-Yusuf commented Nov 12, 2024

Description

Add Mock for Mock Smm Sw Dispatch2 Protocol

For details on how to complete these options and their meaning refer to CONTRIBUTING.md.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Incorporated into GoogleTest

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch. labels Nov 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.60%. Comparing base (4bce300) to head (8f9a0e2).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1217   +/-   ##
===========================================
  Coverage        1.60%    1.60%           
===========================================
  Files            1377     1377           
  Lines          359246   359246           
  Branches         5524     5524           
===========================================
  Hits             5760     5760           
  Misses         353379   353379           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.67% <ø> (ø)
MdePkg 5.60% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@makubacki makubacki requested review from VivianNK and apop5 November 12, 2024 14:52
Rasheed-Yusuf and others added 11 commits December 11, 2024 13:16
Mock Protocol:
MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockFirmwareVolumeBlock.h

Signed-off-by: Rasheed Yusuf <[email protected]>
Cc: Maintainer Shruti Gupta <[email protected]>
Cc: Reviewer Shruti Gupta <[email protected]>
Mock Protocol:
MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockSmmSwDispatch2.h

Signed-off-by: Rasheed Yusuf <[email protected]>
Cc: Maintainer Shruti Gupta <[email protected]>
Cc: Reviewer Shruti Gupta <[email protected]>
Mock Protocol:
MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockSmmSwDispatch2.h

Signed-off-by: Rasheed Yusuf <[email protected]>
Cc: Maintainer Shruti Gupta <[email protected]>
Cc: Reviewer Shruti Gupta <[email protected]>
…eBlock.h

Co-authored-by: Michael Kubacki <[email protected]>
Signed-off-by: Rasheed-Yusuf <[email protected]>
…eBlock.h

This file was added inadvertently.

Signed-off-by: Rasheed-Yusuf <[email protected]>
Mock Protocol:
MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockSmmSwDispatch2.h

Signed-off-by: Rasheed Yusuf <[email protected]>
Cc: Maintainer Shruti Gupta <[email protected]>
Cc: Reviewer Shruti Gupta <[email protected]>
Modifications to use #define MOCK_EFI_SMM_SW_DISPATCH2_PROTOCOL_INSTANCE for MockEfiSmmSwDispatch2Protocol definition

Mock Protocol:
MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockSmmSwDispatch2.h

Signed-off-by: Rasheed Yusuf <[email protected]>
Cc: Maintainer Shruti Gupta <[email protected]>
Cc: Reviewer Shruti Gupta <[email protected]>

Signed-off-by: Rasheed-Yusuf <[email protected]>
@VivianNK VivianNK merged commit 465a5f9 into microsoft:dev/202405 Dec 12, 2024
31 checks passed
ProjectMuBot pushed a commit that referenced this pull request Dec 12, 2024
## Description

Add Mock for Mock Smm Sw Dispatch2 Protocol

For details on how to complete these options and their meaning refer to
[CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md).

- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [ ] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested

Incorporated into GoogleTest

## Integration Instructions

N/A

---------

Signed-off-by: Rasheed Yusuf <[email protected]>
Signed-off-by: Rasheed-Yusuf <[email protected]>
Co-authored-by: Michael Kubacki <[email protected]>
Co-authored-by: Vivian Nowka-Keane <[email protected]>
@Rasheed-Yusuf Rasheed-Yusuf deleted the feature2 branch December 13, 2024 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants