-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Mock for Mock Smm Sw Dispatch2 Protocol #1217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
impact:non-functional
Does not have a functional impact
type:backport
Backport changes in a dev branch PR to its release branch.
labels
Nov 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/202405 #1217 +/- ##
===========================================
Coverage 1.60% 1.60%
===========================================
Files 1377 1377
Lines 359246 359246
Branches 5524 5524
===========================================
Hits 5760 5760
Misses 353379 353379
Partials 107 107
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
makubacki
reviewed
Nov 12, 2024
MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolumeBlock.h
Outdated
Show resolved
Hide resolved
makubacki
reviewed
Nov 12, 2024
MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockSmmSwDispatch2.h
Outdated
Show resolved
Hide resolved
makubacki
reviewed
Nov 12, 2024
MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockFirmwareVolumeBlock.h
Outdated
Show resolved
Hide resolved
apop5
approved these changes
Nov 19, 2024
VivianNK
reviewed
Dec 4, 2024
MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockSmmSwDispatch2.h
Outdated
Show resolved
Hide resolved
MdePkg/Test/Mock/Include/GoogleTest/Protocol/MockSmmSwDispatch2.h
Outdated
Show resolved
Hide resolved
VivianNK
approved these changes
Dec 11, 2024
Mock Protocol: MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockFirmwareVolumeBlock.h Signed-off-by: Rasheed Yusuf <[email protected]> Cc: Maintainer Shruti Gupta <[email protected]> Cc: Reviewer Shruti Gupta <[email protected]>
Mock Protocol: MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockSmmSwDispatch2.h Signed-off-by: Rasheed Yusuf <[email protected]> Cc: Maintainer Shruti Gupta <[email protected]> Cc: Reviewer Shruti Gupta <[email protected]>
Mock Protocol: MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockSmmSwDispatch2.h Signed-off-by: Rasheed Yusuf <[email protected]> Cc: Maintainer Shruti Gupta <[email protected]> Cc: Reviewer Shruti Gupta <[email protected]>
…eBlock.h Co-authored-by: Michael Kubacki <[email protected]> Signed-off-by: Rasheed-Yusuf <[email protected]>
Co-authored-by: Michael Kubacki <[email protected]> Signed-off-by: Rasheed-Yusuf <[email protected]>
…eBlock.h This file was added inadvertently. Signed-off-by: Rasheed-Yusuf <[email protected]>
Mock Protocol: MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockSmmSwDispatch2.h Signed-off-by: Rasheed Yusuf <[email protected]> Cc: Maintainer Shruti Gupta <[email protected]> Cc: Reviewer Shruti Gupta <[email protected]>
Co-authored-by: Vivian Nowka-Keane <[email protected]> Signed-off-by: Rasheed-Yusuf <[email protected]>
Modifications to use #define MOCK_EFI_SMM_SW_DISPATCH2_PROTOCOL_INSTANCE for MockEfiSmmSwDispatch2Protocol definition Mock Protocol: MdePkg\Test\Mock\Include\GoogleTest\Protocol\MockSmmSwDispatch2.h Signed-off-by: Rasheed Yusuf <[email protected]> Cc: Maintainer Shruti Gupta <[email protected]> Cc: Reviewer Shruti Gupta <[email protected]> Signed-off-by: Rasheed-Yusuf <[email protected]>
Signed-off-by: Rasheed-Yusuf <[email protected]>
ProjectMuBot
pushed a commit
that referenced
this pull request
Dec 12, 2024
## Description Add Mock for Mock Smm Sw Dispatch2 Protocol For details on how to complete these options and their meaning refer to [CONTRIBUTING.md](https://github.com/microsoft/mu/blob/HEAD/CONTRIBUTING.md). - [ ] Impacts functionality? - [ ] Impacts security? - [ ] Breaking change? - [ ] Includes tests? - [ ] Includes documentation? - [x] Backport to release branch? ## How This Was Tested Incorporated into GoogleTest ## Integration Instructions N/A --------- Signed-off-by: Rasheed Yusuf <[email protected]> Signed-off-by: Rasheed-Yusuf <[email protected]> Co-authored-by: Michael Kubacki <[email protected]> Co-authored-by: Vivian Nowka-Keane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
impact:non-functional
Does not have a functional impact
type:backport
Backport changes in a dev branch PR to its release branch.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Mock for Mock Smm Sw Dispatch2 Protocol
For details on how to complete these options and their meaning refer to CONTRIBUTING.md.
How This Was Tested
Incorporated into GoogleTest
Integration Instructions
N/A