Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MockVariablePolicyHelperLib #1238

Merged

Conversation

kanechen66
Copy link
Contributor

Description

Provide MockVariablePolicyHelperLib for GoogleTest.

  • Impacts functionality?
  • Impacts security?
  • Breaking change?
  • Includes tests?
  • Includes documentation?
  • Backport to release branch?

How This Was Tested

Tested in module integrated with this MockVariablePolicyHelperLib and pass

Integration Instructions

N/A

@github-actions github-actions bot added impact:non-functional Does not have a functional impact impact:testing Affects testing type:backport Backport changes in a dev branch PR to its release branch. labels Dec 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 1.60%. Comparing base (3def184) to head (b9d2fc2).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/202405    #1238   +/-   ##
===========================================
  Coverage        1.60%    1.60%           
===========================================
  Files            1377     1377           
  Lines          359246   359246           
  Branches         5524     5524           
===========================================
  Hits             5760     5760           
  Misses         353379   353379           
  Partials          107      107           
Flag Coverage Δ
MdeModulePkg 0.67% <ø> (ø)
NetworkPkg 0.55% <ø> (ø)
PolicyServicePkg 30.41% <ø> (ø)
UefiCpuPkg 4.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kanechen66 kanechen66 force-pushed the user/kanechen/mock_variable_policy branch 2 times, most recently from 0d87a2a to 2518caf Compare December 6, 2024 11:55
@kanechen66 kanechen66 force-pushed the user/kanechen/mock_variable_policy branch from 2518caf to 71e541a Compare December 6, 2024 16:23
@kanechen66
Copy link
Contributor Author

@apop5 @VivianNK
Hi all,
could you help to review?
thanks.

@apop5 apop5 requested review from VivianNK and apop5 December 6, 2024 17:01
Copy link
Contributor

@VivianNK VivianNK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to a PR in edk2.

@kanechen66
Copy link
Contributor Author

Please link to a PR in edk2.
here is the EDK2 PR.
tianocore/edk2#6523

@apop5 apop5 merged commit 7161cac into microsoft:dev/202405 Dec 11, 2024
31 checks passed
ProjectMuBot pushed a commit that referenced this pull request Dec 11, 2024
## Description

Provide MockVariablePolicyHelperLib for GoogleTest.



- [ ] Impacts functionality?
- [ ] Impacts security?
- [ ] Breaking change?
- [x] Includes tests?
- [ ] Includes documentation?
- [x] Backport to release branch?

## How This Was Tested
Tested in module integrated with this MockVariablePolicyHelperLib and
pass

## Integration Instructions

N/A

---------

Co-authored-by: Aaron <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact:non-functional Does not have a functional impact impact:testing Affects testing type:backport Backport changes in a dev branch PR to its release branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants