Refactor QUIC to be compatible with Scenario-Based Secnet runs. #414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nibanks
reviewed
Nov 15, 2024
ProjectsByJackHe
changed the title
nibanks
approved these changes
Nov 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After we unified the core scripts, we should instead be pulling the latest version from main instead of relying on existing scripts there.
This PR also includes updates to dashboard code to be compatible with the new data schema.
How was this change tested?
Ran: https://github.com/microsoft/netperf/actions/runs/11904936838,
which used the latest commit hash from the "Standard SecNet Scenarios PR"
This generated the output JSON files and we verified that the dashboard is able to consume this output JSON file.