Skip to content
This repository has been archived by the owner on Nov 16, 2023. It is now read-only.

Remove setuptools scm versioning dependencies for now #417

Merged
merged 1 commit into from
Sep 19, 2019

Conversation

awaemmanuel
Copy link
Contributor

@awaemmanuel awaemmanuel commented Sep 17, 2019

Description

This PR does the following:

  1. Remove setuptools_scm dependencies due to permission issues with pip and scm. pip fails to provide a nice way for setuptools_scm to get access to the temporary scm metadata files it creates when installing the package.
  2. Add instruction that removes the need to update pip if any changes are made to utils package.
  3. Document the known issue with setuptools_scm and pip that fails to give setuptools_scm permission to scm metadata files.
  4. Temporarily removes the dependency on setuptools_scm for automatic versioning because of none issue with pip. Issue on setuptool_scm site is here

These changes are needed because it:
Address the issue experienced by developers when working on the utils_nlp package in development mode. Currently, versioning has to be done manually as we also took out support for setuptools_scm. We'll revisit adding support for automatic versioning when issue is resolved between setuptools_scm and pip developers.

Related Issues

Checklist:

  • My code follows the code style of this project, as detailed in our contribution guidelines.
  • I have added tests.
  • I have updated the documentation accordingly.

@awaemmanuel awaemmanuel force-pushed the emawa/fix/utils-remove-setuptools-dep branch 3 times, most recently from 9cc5fc3 to 693931b Compare September 18, 2019 14:26
…etuptools_scm.

1. And remove setuptools_scm dependencies due to permission issues with pip and scm

2. Add instruction that removes the need to update pip if any changes are made to utils package.

3. Document the known issue with setuptools_scm and pip that fails to give setuptools_scm permission to scm metadata files.
@awaemmanuel awaemmanuel force-pushed the emawa/fix/utils-remove-setuptools-dep branch from 693931b to 6250e06 Compare September 18, 2019 14:35
@saidbleik saidbleik merged commit b5e9b59 into staging Sep 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants