-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading from 2.1.1 to 2.2.0 has diagnostic for file with only comments #31
Comments
Use |
@aeschli thanks! I'll update my code to use that. By the way, I think the changelog should be corrected for 2.2—it says As always, thanks for the library! |
You are right, should have been a major version change. |
The following jsonc file returns a diagnostic in 2.2.0:
Diagnostic:
I know this is a rare scenario, but I believe this is a valid jsonc file and a diagnostic should not be created.
Additionally, in this scenario the return value of
parser.parseTree
is undefined yet the return value is not defined as possibly returning that value.The text was updated successfully, but these errors were encountered: