Supports c++17 #10
Closed
Supports c++17 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: remove mac condition * feat: remove condition
|
Hello, |
|
Thanks for your contribution! The flag changes should come from the runtime which ships the relevant v8 headers, this should be addressed for Electron via electron/electron#36369 Are you compiling this module for Nodejs or Electron ? |
|
Yes, I am compiling this module for Electron. I will address the issue in electron/electron#36369! Thank you for bringing this to my attention. |
|
Closing as issue is addressed in upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
V8 headers now use
c++17by default. This flag was added for supportsc++17.