fix angular test discovery #2467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding link for documentation: karma-runner/karma#3730 |
armanio123
reviewed
May 30, 2023
joj
approved these changes
May 30, 2023
armanio123
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test settings previously always used IPv4 for the listening endpoint. This meant in Node 17+ the tests would not run since node would probe with IPv6. This PR changes it to use localhost which makes the test use the same address that node would use. I tested this change with Node 16 and Node 18 and they both work. Since the change is only to the default values, the user can pass their own values and they will take precedence.