Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added miopenGetConvolutionSpatialDim if ROCm5.5 #14772

Merged
merged 5 commits into from
Mar 3, 2023

Conversation

zstreet87
Copy link
Contributor

@zstreet87 zstreet87 commented Feb 22, 2023

Description

The API should be miopenGetConvolutionSpatialDim(cdesc, &spatial_dim) , NOT miopenGetConvolutionDescriptorSize(cdesc, &spatial_dim)

@jeffdaily
Copy link
Contributor

@cloudhan please merge. We made a mistake with the first PR #14483.

@ytaous
Copy link
Contributor

ytaous commented Mar 2, 2023

/azp run Linux CPU CI Pipeline, Linux CPU Minimal Build E2E CI Pipeline, Linux GPU CI Pipeline, Linux GPU TensorRT CI Pipeline, Linux Nuphar CI Pipeline, Linux OpenVINO CI Pipeline, MacOS CI Pipeline, Windows CPU CI Pipeline, Windows GPU CI Pipeline, Windows GPU TensorRT CI Pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 9 pipeline(s).

@ytaous
Copy link
Contributor

ytaous commented Mar 2, 2023

/azp run onnxruntime-python-checks-ci-pipeline, orttraining-amd-gpu-ci-pipeline, orttraining-linux-ci-pipeline, orttraining-linux-gpu-ci-pipeline, orttraining-ortmodule-distributed, ONNX Runtime Web CI Pipeline, onnxruntime-binary-size-checks-ci-pipeline

@azure-pipelines
Copy link

Azure Pipelines successfully started running 7 pipeline(s).

@causten
Copy link
Contributor

causten commented Mar 2, 2023

I have tested this internally at AMD and it resolves the problem

@cloudhan cloudhan merged commit 6e2ca15 into microsoft:main Mar 3, 2023
mszhanyi pushed a commit that referenced this pull request Mar 9, 2023
The API should be `miopenGetConvolutionSpatialDim(cdesc, &spatial_dim)`, NOT `miopenGetConvolutionDescriptorSize(cdesc, &spatial_dim)`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants