[Quant Tool] Update QDQ Pad, Slice, Softmax #22676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as the input. Fix bug when softmax is excluded from QDQ quantization
yihonglyu
reviewed
Nov 4, 2024
Is the reason that QNN EP has lower latency when the quantization parameters are equal because it can fuse |
yihonglyu
reviewed
Nov 4, 2024
I imagine this is the case, although I don't know for sure. We only know this from inference latency measurements. |
sophies927
added
release:1.20.1
triage:approved
yihonglyu
reviewed
Nov 5, 2024
yihonglyu
reviewed
Nov 5, 2024
adrianlizarraga
commented
Nov 5, 2024
yihonglyu
reviewed
Nov 5, 2024
yihonglyu
reviewed
Nov 5, 2024
adrianlizarraga
commented
Nov 5, 2024
yihonglyu
reviewed
Nov 6, 2024
yihonglyu
approved these changes
Nov 6, 2024
adrianlizarraga
deleted the
adrianl/quant-tool-slice-pad-softmax-updates
branch
adrianlizarraga
added a commit
that referenced
this pull request
Nov 6, 2024
### Description Updates python quantization tool: - Ensures QDQ Pad has equal quantization parameters across input and output for certain Pad configurations. - Ensures QDQ Slice always has equal quantization parameters across input and output. - Fixes bug when Softmax is _excluded_ from quantization. ### Motivation and Context QDQ Pad and Slice have lower latency on QNN EP when their quantization parameters are equal.
yf711
pushed a commit
that referenced
this pull request
Nov 11, 2024
### Description Updates python quantization tool: - Ensures QDQ Pad has equal quantization parameters across input and output for certain Pad configurations. - Ensures QDQ Slice always has equal quantization parameters across input and output. - Fixes bug when Softmax is _excluded_ from quantization. ### Motivation and Context QDQ Pad and Slice have lower latency on QNN EP when their quantization parameters are equal.
ishwar-raut1
pushed a commit
to ishwar-raut1/onnxruntime
that referenced
this pull request
Nov 19, 2024
### Description Updates python quantization tool: - Ensures QDQ Pad has equal quantization parameters across input and output for certain Pad configurations. - Ensures QDQ Slice always has equal quantization parameters across input and output. - Fixes bug when Softmax is _excluded_ from quantization. ### Motivation and Context QDQ Pad and Slice have lower latency on QNN EP when their quantization parameters are equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates python quantization tool:
Motivation and Context
QDQ Pad and Slice have lower latency on QNN EP when their quantization parameters are equal.