This repository has been archived by the owner on Jun 6, 2024. It is now read-only.
[Rest Server] Add get job api v2 #2851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add get job api v2.
Binyang2014
reviewed
May 29, 2019
Binyang2014
approved these changes
May 29, 2019
Split not found error.
Binyang2014
reviewed
May 30, 2019
src/rest-server/src/models/v2/job.js
Outdated
| if (response.status !== status('OK')) { | ||
| if (response.status === status('OK')) { | ||
| return response.data; | ||
| } else if (response.status === status('Not Found')) { |
There was a problem hiding this comment.
remove else
if (status === statue('OK')) {
return ...;
}
if (...) {
throw ...
}| @@ -35,7 +35,7 @@ const update = asyncHandler(async (req, res) => { | |||
| throw createError('Conflict', 'ConflictJobError', `Job ${frameworkName} already exists.`); | |||
| } | |||
| } catch (error) { | |||
| if (error.code === 'UnknownError') { | |||
| if (error.code !== 'NoJobError') { | |||
There was a problem hiding this comment.
Can log this?
if (error.code === 'NoJobError') {
log.Debug('...');
return;
}
throw error;There was a problem hiding this comment.
it's not an error if job not found here, no need to log.
Binyang2014
approved these changes
May 30, 2019
sunqinzheng
approved these changes
May 30, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add get job api v2.