Skip to content
This repository has been archived by the owner on Jun 6, 2024. It is now read-only.

Binyli/job submit #2885

Merged
merged 10 commits into from
Jun 13, 2019
Merged

Binyli/job submit #2885

merged 10 commits into from
Jun 13, 2019

Conversation

Binyang2014
Copy link
Contributor

This PR contains following changes；

  1. Add converter to convert input to protocol format
  2. Enhance some widgets
  3. Performance improve for textField, only render when onBlur happends

@Binyang2014
add converter
9275591
@Binyang2014
Add parameter func and finish some convert task
3d1f514 
Add parameter func
Finish convert tasks
@Binyang2014
performance improve and style change
a5cebe1 
For text filed doesn't render for every value change,
only render when blur happends

minor style change
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 53.324% when pulling a5cebe1 on binyli/job_submit into 9b2f3de on feature/job_submission.

@coveralls
Copy link

coveralls commented Jun 5, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 53.324% when pulling 53cc2b5 on binyli/job_submit into 9b2f3de on feature/job_submission.

@debuggy debuggy mentioned this pull request Jun 6, 2019
Closed
13 tasks
@debuggy
Copy link
Contributor

debuggy commented Jun 10, 2019

image
the command field not aligned with title, and the blank might be a little shorter

@debuggy
Copy link
Contributor

debuggy commented Jun 10, 2019 •
edited
Loading

image

Maybe this row should align with top

@debuggy
Copy link
Contributor

debuggy commented Jun 10, 2019 •
edited
Loading

The Ports, Task retry count, Completion and Deployment sections should be put into a more trivial place

debuggy
debuggy reviewed Jun 10, 2019
View reviewed changes
Copy link
Contributor

@debuggy debuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As the convention, the file name should be in lower cases

@Binyang2014 Binyang2014 requested a review from debuggy June 11, 2019 08:56
@debuggy debuggy closed this Jun 12, 2019
@debuggy debuggy reopened this Jun 12, 2019
debuggy
debuggy reviewed Jun 12, 2019
View reviewed changes
Copy link
Contributor

@debuggy debuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2885 (review)

As the file name comment: in this project, the name of files are all like xword-yword.suffix, maybe we should follow this convention.

@Binyang2014
Copy link
Contributor Author

#2885 (review)

As the file name comment: in this project, the name of files are all like xword-yword.suffix, maybe we should follow this convention.

Fine, will fix this issue

debuggy
debuggy approved these changes Jun 13, 2019
View reviewed changes
Copy link
Contributor

@debuggy debuggy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Binyang2014 Binyang2014 merged commit 46e8319 into feature/job_submission Jun 13, 2019
Binyang2014 added a commit that referenced this pull request Jun 13, 2019
@Binyang2014
Binyli/job submit (#2885)
5e7eede 
Contain following changes:
1. CSS change
2. Add simple converter to convert input to job submission protocol
3. Task role widget refactor
4. Rename files name
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@debuggy debuggy debuggy approved these changes

@sunqinzheng sunqinzheng Awaiting requested review from sunqinzheng

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Binyang2014 @coveralls @debuggy