Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't include binder events in default CLR events #1756

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elinor-fung
Copy link
Member

@elinor-fung elinor-fung commented Nov 21, 2022

The binder events - for Fusion in .NET Framework and assembly load tracing in .NET Core/5+ - are for the targeted scenario of assembly bind tracing. They aren't generally helpful to have on by default and can come with a significant performance cost. This removes the binder events from ClrTraceEventParser.Keywords.Default, since I don't think those intentionally verbose events make sense in the default set.

@elinor-fung elinor-fung reopened this Nov 21, 2022
@brianrob
Copy link
Member

@elinor-fung thanks for submitting this. While these events can be costly, they are often quite helpful, as ETW traces are often used for troubleshooting issues that are related to assembly loading. A good example is understanding NGEN image rejection on .NET Framework. We include these by default because we use them enough and they aren't so costly that we want to have to ask for them each time we need them. Unless something has changed, my preference would be to leave them in the default set.

@elinor-fung
Copy link
Member Author

@brianrob Can you point me at which events those are? From what I could tell, all the actual binder events in .NET Framework come through the Microsoft-Windows-DotNETRuntimePrivate provider and nothing actually comes through the FusionKeyword for Microsoft-Windows-DotNETRuntime in Framework.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants