Skip to content

Commit

Permalink
feat(firefox): bump to 1166 (#3557)
Browse files Browse the repository at this point in the history
  • Loading branch information
yury-s authored Aug 20, 2020
1 parent e2bb6a0 commit 071931e
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 2 deletions.
2 changes: 1 addition & 1 deletion browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
{
"name": "firefox",
"revision": "1160",
"revision": "1166",
"download": true
},
{
Expand Down
19 changes: 19 additions & 0 deletions src/firefox/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -262,6 +262,14 @@ export module Protocol {
colorScheme: ("dark"|"light"|"no-preference")|null;
};
export type setColorSchemeReturnValue = void;
export type setScreencastOptionsParameters = {
browserContextId?: string;
dir: string;
width: number;
height: number;
scale?: number;
};
export type setScreencastOptionsReturnValue = void;
}
export module Page {
export type DOMPoint = {
Expand Down Expand Up @@ -398,6 +406,13 @@ export module Protocol {
workerId: string;
message: string;
}
export type screencastStartedPayload = {
uid: string;
file: string;
}
export type screencastStoppedPayload = {
uid: string;
}
export type closeParameters = {
runBeforeUnload?: boolean;
};
Expand Down Expand Up @@ -935,6 +950,8 @@ export module Protocol {
"Page.workerCreated": Page.workerCreatedPayload;
"Page.workerDestroyed": Page.workerDestroyedPayload;
"Page.dispatchMessageFromWorker": Page.dispatchMessageFromWorkerPayload;
"Page.screencastStarted": Page.screencastStartedPayload;
"Page.screencastStopped": Page.screencastStoppedPayload;
"Runtime.executionContextCreated": Runtime.executionContextCreatedPayload;
"Runtime.executionContextDestroyed": Runtime.executionContextDestroyedPayload;
"Runtime.console": Runtime.consolePayload;
Expand Down Expand Up @@ -974,6 +991,7 @@ export module Protocol {
"Browser.getCookies": Browser.getCookiesParameters;
"Browser.setOnlineOverride": Browser.setOnlineOverrideParameters;
"Browser.setColorScheme": Browser.setColorSchemeParameters;
"Browser.setScreencastOptions": Browser.setScreencastOptionsParameters;
"Page.close": Page.closeParameters;
"Page.setFileInputFiles": Page.setFileInputFilesParameters;
"Page.addBinding": Page.addBindingParameters;
Expand Down Expand Up @@ -1046,6 +1064,7 @@ export module Protocol {
"Browser.getCookies": Browser.getCookiesReturnValue;
"Browser.setOnlineOverride": Browser.setOnlineOverrideReturnValue;
"Browser.setColorScheme": Browser.setColorSchemeReturnValue;
"Browser.setScreencastOptions": Browser.setScreencastOptionsReturnValue;
"Page.close": Page.closeReturnValue;
"Page.setFileInputFiles": Page.setFileInputFilesReturnValue;
"Page.addBinding": Page.addBindingReturnValue;
Expand Down
2 changes: 1 addition & 1 deletion test/popup.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,7 @@ it('should not dispatch binding on a closed page', async function({browser, serv
]);
await context.close();
if (options.FIREFOX)
expect(messages.join('|')).toBe('alreadyclosed');
expect(messages.join('|')).toBe('close');
else
expect(messages.join('|')).toBe('binding|close');
});

0 comments on commit 071931e

Please sign in to comment.