fix(chromium): disable lazy loading iframes (#3535)

These do not play nicely with our "page is loaded when all frames are loaded" logic.
microsoft · Aug 19, 2020 · 0a22e27 · 0a22e27
1 parent f13cebc
commit 0a22e27
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 1 deletion.
diff --git a/src/server/chromium.ts b/src/server/chromium.ts
@@ -162,7 +162,7 @@ const DEFAULT_ARGS = [
   '--disable-dev-shm-usage',
   '--disable-extensions',
   // BlinkGenPropertyTrees disabled due to crbug.com/937609
-  '--disable-features=TranslateUI,BlinkGenPropertyTrees,ImprovedCookieControls,SameSiteByDefaultCookies',
+  '--disable-features=TranslateUI,BlinkGenPropertyTrees,ImprovedCookieControls,SameSiteByDefaultCookies,LazyFrameLoading',
   '--disable-hang-monitor',
   '--disable-ipc-flooding-protection',
   '--disable-popup-blocking',

diff --git a/test/assets/frames/lazy-frame.html b/test/assets/frames/lazy-frame.html
@@ -0,0 +1,6 @@
+<div style="height: 1000px; width: 1000px; background: red">One</div>
+<div style="height: 1000px; width: 1000px; background: blue">Two</div>
+<div style="height: 1000px; width: 1000px; background: red">Three</div>
+<div style="height: 1000px; width: 1000px; background: blue">Four</div>
+<div style="height: 1000px; width: 1000px; background: red">Five</div>
+<iframe loading="lazy" src='./frame.html'></iframe>
diff --git a/test/page-goto.spec.ts b/test/page-goto.spec.ts
@@ -491,3 +491,8 @@ it.skip(true)('extraHttpHeaders should be pushed to provisional page', async({pa
   expect(htmlReq.headers['foo']).toBe(undefined);
   expect(cssReq.headers['foo']).toBe('bar');
 });
+
+it('should work with lazy loading iframes', async({page, server}) => {
+  await page.goto(server.PREFIX + '/frames/lazy-frame.html');
+  expect(page.frames().length).toBe(2);
+});