Skip to content

Commit

Permalink
devops: stop relying on ubuntu stock ffmpeg (#3882)
Browse files Browse the repository at this point in the history
This patch bakes ffmpeg-linux r1001 into our NPM package.

This increases NPM package size from 4.2MB to 6.7MB.

Fixes #3845
  • Loading branch information
aslushnikov authored Sep 15, 2020
1 parent 459d857 commit 430f2be
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 9 deletions.
13 changes: 4 additions & 9 deletions src/server/chromium/videoRecorder.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ import { assert } from '../../utils/utils';
import { launchProcess } from '../processLauncher';
import { Progress, ProgressController } from '../progress';
import * as types from '../types';
import { spawnAsync } from '../validateDependencies';

const fps = 25;

Expand Down Expand Up @@ -62,16 +61,12 @@ export class VideoRecorder {

let ffmpegPath = 'ffmpeg';
const binPath = path.join(__dirname, '../../../third_party/ffmpeg/');
if (os.platform() === 'win32') {
if (os.platform() === 'win32')
ffmpegPath = path.join(binPath, os.arch() === 'x64' ? 'ffmpeg-win64.exe' : 'ffmpeg-win32.exe');
} else if (os.platform() === 'darwin') {
else if (os.platform() === 'darwin')
ffmpegPath = path.join(binPath, 'ffmpeg-mac');
} else {
// Look for ffmpeg in PATH.
const {code, error} = await spawnAsync(ffmpegPath, ['-version'], {});
if (code !== 0 || error)
throw new Error('ffmpeg not found.\nInstall missing packages with:\n sudo apt-get install ffmpeg');
}
else
ffmpegPath = path.join(binPath, 'ffmpeg-linux');
const { launchedProcess, gracefullyClose } = await launchProcess({
executablePath: ffmpegPath,
args,
Expand Down
Binary file added third_party/ffmpeg/ffmpeg-linux
Binary file not shown.

0 comments on commit 430f2be

Please sign in to comment.