cherry-pick(#34544): fix(aria): disregard text area textContent

microsoft · Jan 30, 2025 · 4b7794b · 4b7794b
1 parent 1efbedd
commit 4b7794b
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/playwright-core/src/server/injected/ariaSnapshot.ts b/packages/playwright-core/src/server/injected/ariaSnapshot.ts
@@ -57,7 +57,8 @@ export function generateAriaTree(rootElement: Element): AriaSnapshot {
 
     if (node.nodeType === Node.TEXT_NODE && node.nodeValue) {
       const text = node.nodeValue;
-      if (text)
+      // <textarea>AAA</textarea> should not report AAA as a child of the textarea.
+      if (ariaNode.role !== 'textbox' && text)
         ariaNode.children.push(node.nodeValue || '');
       return;
     }

diff --git a/tests/page/page-aria-snapshot.spec.ts b/tests/page/page-aria-snapshot.spec.ts
@@ -605,3 +605,16 @@ it('should escape special yaml values', async ({ page }) => {
     - textbox: "555"
   `);
 });
+
+it('should not report textarea textContent', async ({ page }) => {
+  await page.setContent(`<textarea>Before</textarea>`);
+  await checkAndMatchSnapshot(page.locator('body'), `
+    - textbox: Before
+  `);
+  await page.evaluate(() => {
+    document.querySelector('textarea').value = 'After';
+  });
+  await checkAndMatchSnapshot(page.locator('body'), `
+    - textbox: After
+  `);
+});