Skip to content

Commit

Permalink
feat(webkit): bump to 1357 (#4154)
Browse files Browse the repository at this point in the history
  • Loading branch information
JoelEinbinder authored Oct 19, 2020
1 parent 347dd24 commit 86ef956
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 3 deletions.
2 changes: 1 addition & 1 deletion browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
},
{
"name": "webkit",
"revision": "1353",
"revision": "1357",
"download": true
}
]
Expand Down
23 changes: 23 additions & 0 deletions src/server/webkit/protocol.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4540,6 +4540,27 @@ Left=1, Right=2, Middle=4, Back=8, Forward=16, None=0.
}
export type dispatchMouseEventReturnValue = {
}
/**
* Dispatches a tap event to the page.
*/
export type dispatchTapEventParameters = {
/**
* X coordinate of the event relative to the main frame's viewport in CSS pixels.
*/
x: number;
/**
* Y coordinate of the event relative to the main frame's viewport in CSS pixels. 0 refers to
the top of the viewport and Y increases as it proceeds towards the bottom of the viewport.
*/
y: number;
/**
* Bit field representing pressed modifier keys. Alt=1, Ctrl=2, Meta/Command=4, Shift=8
(default: 0).
*/
modifiers?: number;
}
export type dispatchTapEventReturnValue = {
}
}

export module Inspector {
Expand Down Expand Up @@ -8607,6 +8628,7 @@ Left=1, Right=2, Middle=4, Back=8, Forward=16, None=0.
"IndexedDB.clearObjectStore": IndexedDB.clearObjectStoreParameters;
"Input.dispatchKeyEvent": Input.dispatchKeyEventParameters;
"Input.dispatchMouseEvent": Input.dispatchMouseEventParameters;
"Input.dispatchTapEvent": Input.dispatchTapEventParameters;
"Inspector.enable": Inspector.enableParameters;
"Inspector.disable": Inspector.disableParameters;
"Inspector.initialized": Inspector.initializedParameters;
Expand Down Expand Up @@ -8890,6 +8912,7 @@ Left=1, Right=2, Middle=4, Back=8, Forward=16, None=0.
"IndexedDB.clearObjectStore": IndexedDB.clearObjectStoreReturnValue;
"Input.dispatchKeyEvent": Input.dispatchKeyEventReturnValue;
"Input.dispatchMouseEvent": Input.dispatchMouseEventReturnValue;
"Input.dispatchTapEvent": Input.dispatchTapEventReturnValue;
"Inspector.enable": Inspector.enableReturnValue;
"Inspector.disable": Inspector.disableReturnValue;
"Inspector.initialized": Inspector.initializedReturnValue;
Expand Down
4 changes: 2 additions & 2 deletions test/browsercontext-viewport-mobile.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,8 +131,8 @@ describe('mobile viewport', (suite, { browserName }) => {
await context.close();
});

it('should emulate the hover media feature', (test, { browserName }) => {
test.fail(browserName === 'webkit');
it('should emulate the hover media feature', (test, { browserName, platform }) => {
test.fail(browserName === 'webkit' && platform === 'darwin');
}, async ({playwright, browser}) => {
const iPhone = playwright.devices['iPhone 6'];
const mobilepage = await browser.newPage({ ...iPhone });
Expand Down

0 comments on commit 86ef956

Please sign in to comment.