Skip to content

Commit

Permalink
feat(firefox): roll Firefox to r1200 (#4316)
Browse files Browse the repository at this point in the history
This roll includes:
- fix for the firefox flakiness related to popups
- fix for browser context closing with beforeunload events

References #4021
  • Loading branch information
aslushnikov authored Nov 3, 2020
1 parent 1c39689 commit 8fed0b3
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 1 addition & 1 deletion browsers.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
},
{
"name": "firefox",
"revision": "1198",
"revision": "1200",
"download": true
},
{
Expand Down
2 changes: 0 additions & 2 deletions test/beforeunload.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@ it('should close browser with beforeunload page', (test, {browserName}) => {
});

it('should close browsercontext with beforeunload page', (test, {browserName}) => {
test.fixme(browserName === 'firefox');
}, async ({server, contextFactory }) => {
const browserContext = await contextFactory();
const page = await browserContext.newPage();
Expand Down Expand Up @@ -75,7 +74,6 @@ it('should run beforeunload if asked for', async ({context, server, isChromium,

it('should access page after beforeunload', (test, { browserName }) => {
test.fixme(browserName === 'chromium');
test.fixme(browserName === 'firefox');
}, async ({contextFactory, server}) => {
const context = await contextFactory();
const page = await context.newPage();
Expand Down

0 comments on commit 8fed0b3

Please sign in to comment.