Skip to content

Commit

Permalink
test: run crash tests with chromium wire (#4026)
Browse files Browse the repository at this point in the history
  • Loading branch information
dgozman authored Oct 1, 2020
1 parent b74a6b7 commit 920cc7c
Showing 1 changed file with 2 additions and 5 deletions.
7 changes: 2 additions & 5 deletions test/page-event-crash.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ function crash(page, toImpl, browserName) {
}

describe('', (suite, { browserName, platform, wire }) => {
suite.fixme(wire);
suite.skip(wire && browserName !== 'chromium');
suite.flaky(browserName === 'firefox' && platform === 'win32');
}, () => {
it('should emit crash event when page crashes', async ({page, browserName, toImpl}) => {
Expand Down Expand Up @@ -63,10 +63,7 @@ describe('', (suite, { browserName, platform, wire }) => {
expect(error.message).toContain('Navigation failed because page crashed');
});

it('should be able to close context when page crashes', (test, { browserName, platform, wire }) => {
test.fixme(wire);
test.flaky(browserName === 'firefox' && platform === 'win32');
}, async ({page, browserName, toImpl}) => {
it('should be able to close context when page crashes', async ({page, browserName, toImpl}) => {
await page.setContent(`<div>This page should crash</div>`);
crash(page, toImpl, browserName);
await page.waitForEvent('crash');
Expand Down

0 comments on commit 920cc7c

Please sign in to comment.