Skip to content

Commit

Permalink
devops: avoid running publish on external contrib (#3257)
Browse files Browse the repository at this point in the history
Everytime I sync my fork to upstream, I get failure notifications:

```
Run failed for master (3edfb2a)
Repository: rwoll/playwright
Workflow: devrelease
Duration: 10 minutes and 34.0 seconds
Finished: 2020-07-31 18:30:13 UTC
```

Since forks should never have the necessary secrets to publish
the npm and Docker packages, we limit the running of these jobs to avoid
noisy failures for contributors.
  • Loading branch information
rwoll authored Jul 31, 2020
1 parent ba9030e commit cbd33f9
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/publish_canary_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
publish-canary-docker:
name: "publish to DockerHub"
runs-on: ubuntu-18.04
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/publish_canary_npm.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ jobs:
publish-canary-npm:
name: "publish to NPM"
runs-on: ubuntu-18.04
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down
2 changes: 2 additions & 0 deletions .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ jobs:
publish-npm-release:
name: "publish to NPM"
runs-on: ubuntu-18.04
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand All @@ -27,6 +28,7 @@ jobs:
publish-docker-release:
name: "publish to DockerHub"
runs-on: ubuntu-18.04
if: github.repository == 'microsoft/playwright'
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v1
Expand Down

0 comments on commit cbd33f9

Please sign in to comment.