fix(screencast): dont throw from frameAck if target is closed (#3702)

microsoft · Sep 1, 2020 · db9b8a0 · db9b8a0
1 parent 1877c29
commit db9b8a0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/server/chromium/crPage.ts b/src/server/chromium/crPage.ts
@@ -743,7 +743,8 @@ class FrameSession {
       return;
     const buffer = Buffer.from(payload.data, 'base64');
     this._videoRecorder.writeFrame(buffer, payload.metadata.timestamp!);
-    this._client.send('Page.screencastFrameAck', {sessionId: payload.sessionId});
+    // The target may be closed before receiving the ack.
+    this._client.send('Page.screencastFrameAck', {sessionId: payload.sessionId}).catch(() => {});
   }
 
   async _startScreencast(screencastId: string, options: types.PageScreencastOptions): Promise<void> {

diff --git a/test/screencast.spec.ts b/test/screencast.spec.ts
@@ -193,8 +193,7 @@ describe('screencast', suite => {
 
   it('should capture navigation', test => {
     test.flaky(options.CHROMIUM && MAC);
-    test.flaky(options.FIREFOX && LINUX && !options.HEADLESS);
-    test.flaky(options.FIREFOX && WIN);
+    test.flaky(options.FIREFOX);
     test.flaky(options.WEBKIT);
   }, async ({page, tmpDir, server, videoPlayer, toImpl}) => {
     const videoFile = path.join(tmpDir, 'v.webm');