-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REGRESSION]: Regular WebKit crashes after specific screenshot steps #22903
Comments
Thanks for the repro. Your repository looks like a production project with a lot of dependencies that I am hesitant installing locally. Could you provide a reduced test case that demonstrates the issue and nothing but the issue? Ideally it would only use playwright and point at the live version of your app (https://beta.prereview.org/.?) |
Thanks @pavelfeldman, I'm seeing if I can isolate the problem more. The two cases where it fails have mocked errors on the server so can't be recreated using the live service (e.g. https://github.com/PREreview/prereview.org/blob/883c91c75a2f76d7844b70ad4f42d6e362728a45/integration/publishing-a-prereview.spec.ts#L1202-L1218 sets up a HTTP request from the server which will time out). I know the full project is a bit much, but running Is there any way of debugging WebKit to discover why it crashes? I've seen Chromium crash previously, and I remember seeing a stack trace in the debug output helping me to see that was related to Playwright's patching. I'm struggling to work out how to produce a reduced test case at the moment... |
I am facing exactly same problem with Webkit on
SolutionI tried the canary release Similar Issue (#22429)Not exactly a similar issue but definitely the same scenario. It was failing with Webkit on Ubuntu (working fine on macOS, same is the case this time as well), tried the canary release which resolved the issue. |
@pinanks Thanks!
@thewilkybarkid could you give it a try as well? |
Thanks @pinanks, I've run it on |
Crash backtrace:
1837 bad 1837 -> 1838 https://github.com/microsoft/playwright-browsers/pull/399 Looks like WebKit/WebKit@dc4c470 aka. https://bugs.webkit.org/show_bug.cgi?id=255785 was fixing it. |
Closing since its fixed upstream. |
Extracted from #22790 (comment)
Context:
Code Snippet
I haven't been able to narrow down a test case, but this can be seen in an actual project (PREreview/prereview.org#885):
(You'll need Git LFS installed to get the existing snapshots.)
Describe the bug
Two tests are regularly failing in WebKit (with JavaScript enabled):
I can get some debug info that shows WebKit is crashing, but without any details about why it's crashing:
It seems to crash shortly after an
expect(page).toHaveScreenshot()
step passes (https://github.com/PREreview/prereview.org/blob/883c91c75a2f76d7844b70ad4f42d6e362728a45/integration/publishing-a-prereview.spec.ts#L1223).
I've not been able to recreate the failure with the screenshot-steps removed, nor with JavaScript disabled.
The text was updated successfully, but these errors were encountered: