-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Versioned Docker files with browsers #2926
Comments
References microsoft#2926
- Repository name has to start with `public/` to be exported to dockerhub. - Remove `DOCKER_USERNAME` to avoid unnecessary masking in our logs. - Publish dev versions of Docker image only when changes to docker file happen. (this is why NPM publishing and Docker publishing for dev releases are now separate). - Release publishing in two separate jobs to make them independent. References microsoft#2926
- Repository name has to start with `public/` to be exported to dockerhub. - Remove `DOCKER_USERNAME` to avoid unnecessary masking in our logs. - Publish dev versions of Docker image only when changes to docker file happen. (this is why NPM publishing and Docker publishing for dev releases are now separate). - Release publishing in two separate jobs to make them independent. References #2926
This patch bakes browsers into docker image. Important observations: - We now re-build docker image everytime we roll browsers. - Docker image size almost doubles: from `225MB` to `496MB`. References microsoft#2926
This patch bakes browsers into docker image. Important observations: - We now re-build docker image everytime we roll browsers. - Docker image size almost doubles: from `225MB` to `496MB`. References microsoft#2926
This patch bakes browsers into docker image. Important observations: - We now re-build docker image everytime we roll browsers. - Docker image size almost doubles: from `225MB` to `496MB`. References #2926
Very good point. Also it would be great to have a yarn installed as requested here: Putting our dockerfile here, probably it will save some time for anybody.
|
This patch: - refactors script to output per-browser package dependencies. This is to aid with per-browser docker setup and Playwright github action. - sorts package maps for both Ubuntu 18.04 and Ubuntu 20.04 alphabetically (and removes a stray dependency) - hardcodes `DLOPEN` libraries for the browsers References microsoft#2926
With v1.3.0, we'll publish |
It turns out Github Actions have docker pre-installed. This patch unifies the codepaths that we use to build docker image locally and to publish it from CI. As a result, there's no extra `--prepare-context` argument in `//docs/docker/build.sh` that was used solely on CI. References microsoft#2926
It turns out Github Actions have docker pre-installed. This patch unifies the codepaths that we use to build docker image locally and to publish it from CI. As a result, there's no extra `--prepare-context` argument in `//docs/docker/build.sh` that was used solely on CI. References #2926
Manual login appeared to be successful, but rejected docker push. References microsoft#2926
Manual login appeared to be successful, but rejected docker push. References #2926
So far:
The per-vendor docker images haven't been requested much. Closing this for now. |
Docker files for Playwright should be versioned with Playwright versions and come with the browsers pre-installed. Rationale:
@aslushnikov, wdyt?
Actions:
The text was updated successfully, but these errors were encountered: