Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser(webkit): fix scrolling with mobile viewport #2468

Merged
merged 1 commit into from
Jun 4, 2020

Conversation

JoelEinbinder
Copy link
Contributor

Previously setDelegatesScrolling was being called when we were in fixed layout mode on linux, but nothing was actually delegating the scrolling anywhere. This caused scrollIntoView to fail.

This patch does not fix scrolling with a mouse wheel when in headful mode + mobile viewport. Our mobile viewport causes scrollbars to be disabled, which also disabled mouse wheel scrolling.

#2179

@yury-s
Copy link
Member

yury-s commented Jun 4, 2020

One thing that worries me is that after clicking on "About" link from the scenario in the bug report the new page stays blank for me. I've tried to click one of the links programmatically on that page but it didn't work

  const page = await context.newPage();
  await page.goto('https://www.google.com/?hl=en');
  await page.click('text="About"');
  await new Promise(r => setTimeout(r, 1000));
  await page.waitForLoadState();
  const link = await page.$('text=See the latest');
  console.log('found link: ' + link);
  await link.click('text=See the latest');

In any case there are probably more rendering issues in fixed layout mode and GTK, we can look at them separately.

@yury-s yury-s merged commit 601eddf into microsoft:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants