Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(capabilities): test that video tag can play video #2477

Merged
merged 2 commits into from
Jun 6, 2020
Merged

test(capabilities): test that video tag can play video #2477

merged 2 commits into from
Jun 6, 2020

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Jun 5, 2020

dgozman
dgozman reviewed Jun 5, 2020
View reviewed changes
test/assets/video.html

<video width="400" controls>
<source src="movie.mp4" type="video/mp4">
<source src="movie.ogv" type="video/ogg">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I tried this, our WebKit on mac did not play the ogg. It does a range request that's not supported by our test server.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's unfortunate, marking it as failing in WebKit for now anyway.

@yury-s yury-s merged commit 54f07f9 into microsoft:master Jun 6, 2020
@yury-s yury-s deleted the video-tag branch June 6, 2020 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgozman dgozman dgozman left review comments

@pavelfeldman pavelfeldman pavelfeldman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yury-s @pavelfeldman @dgozman